Skip to content

feat: add implementation of math/base/special/sqrt1pm1f#10318

Open
shubham220420 wants to merge 5 commits intostdlib-js:developfrom
shubham220420:shubham2204-sqrt1pm1f
Open

feat: add implementation of math/base/special/sqrt1pm1f#10318
shubham220420 wants to merge 5 commits intostdlib-js:developfrom
shubham220420:shubham2204-sqrt1pm1f

Conversation

@shubham220420
Copy link
Copy Markdown
Contributor

@shubham220420 shubham220420 commented Feb 16, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Ref: #649

Description

What is the purpose of this pull request?

This pull request:

  • This PR adds the C and JS implementation of math/base/special/sqrt1pm1f.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@shubham220420
feat: add implementation of math/base/special/sqrt1pm1f
52058bb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 16, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrt1pm1f $\color{green}212/212$
$\color{green}+0.00%$ 		$\color{green}9/9$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}212/212$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@whizzel
Copy link
Copy Markdown
Contributor

whizzel commented Feb 16, 2026

@shubham220420 Since this is a float32 implementation (sqrt1pm1f), should this use
@stdlib/math/base/special/expm1f instead of expm1?

Using the float64 version here would introduce mixed precision in an *f
module. Just wanted to confirm if that was intentional.

@shubham220420
Copy link
Copy Markdown
Contributor Author

shubham220420 commented Feb 16, 2026 •
edited
Loading

@shubham220420 Since this is a float32 implementation (sqrt1pm1f), should this use @stdlib/math/base/special/expm1f instead of expm1?

Using the float64 version here would introduce mixed precision in an *f module. Just wanted to confirm if that was intentional.

expm1 was used since there is no implementation for expm1f as of now in the codebase, therefore the result is rounded-of using f32 as you can see in the implementation,
once the expm1f implementation is added ( i am working on that too ), this code can be refactored in future to use that instead of expm1

@whizzel
Copy link
Copy Markdown
Contributor

whizzel commented Feb 16, 2026

Got it, that makes sense.

Planeshifter
Planeshifter requested changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial round of review comments. Thanks for working on this!

Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/README.md Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/test/test.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/test/test.native.js Outdated
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 16, 2026
@shubham220420
fix: apply code suggestions
5df76ca 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 16, 2026
@shubham220420 shubham220420 mentioned this pull request Feb 16, 2026
Merged
7 tasks
Planeshifter
Planeshifter requested changes Feb 17, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/README.md Outdated
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Feb 17, 2026
@shubham220420
fix: apply code suggestions
63d8136 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 17, 2026
Planeshifter
Planeshifter requested changes Feb 18, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/index.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/native.js Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/docs/types/index.d.ts Outdated
Comment thread ...ode_modules/@stdlib/math/base/special/sqrt1pm1f/include/stdlib/math/base/special/sqrt1pm1f.h Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/src/main.c Outdated
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/docs/repl.txt Outdated
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Feb 18, 2026
@shubham220420
fix: apply code suggestions
ff3cab8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 18, 2026
gunjjoshi
gunjjoshi reviewed Mar 1, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/main.js
Planeshifter
Planeshifter requested changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing this PR will require presence of math/base/special/expm1.

Comment thread lib/node_modules/@stdlib/math/base/special/sqrt1pm1f/lib/main.js Outdated
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 4, 2026
@shubham220420
Copy link
Copy Markdown
Contributor Author

shubham220420 commented Mar 4, 2026

Landing this PR will require presence of math/base/special/expm1.

i guess you meant to say expm1f here, and thats right, we can wait until its added and then I can refactor this code to use that.

@shubham220420
fix: apply code suggestions
4c6fb17 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 4, 2026
@Planeshifter Planeshifter added status: Blocked Issue or pull request which is currently blocked. and removed Needs Review A pull request which needs code review. labels Mar 4, 2026
@navyansh007 navyansh007 mentioned this pull request Mar 29, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunjjoshi gunjjoshi gunjjoshi left review comments

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. status: Blocked Issue or pull request which is currently blocked.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shubham220420 @stdlib-bot @whizzel @Planeshifter @gunjjoshi